[ http://issues.apache.org/jira/browse/HADOOP-611?page=comments#action_12443319 ] Doug Cutting commented on HADOOP-611: -------------------------------------
Looks good overall. The 'deleteInput' parameter seems odd there. When would the input files be deleted? As soon as the last entry is consumed? What if the merger is dropped before all inputs are consumed? Perhaps the iterator or Sorter should instead have a method that deletes things, that can be called in a finally clause around merge iteration? > SequenceFile.Sorter should have a merge method that returns an iterator > ----------------------------------------------------------------------- > > Key: HADOOP-611 > URL: http://issues.apache.org/jira/browse/HADOOP-611 > Project: Hadoop > Issue Type: New Feature > Components: io > Reporter: Owen O'Malley > Assigned To: Devaraj Das > Fix For: 0.8.0 > > > SequenceFile.Sorter should get a new merge method that returns an iterator > over the keys/values. > The current merge method should become a simple method that gets the iterator > and writes the records out to a file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
