[ 
http://issues.apache.org/jira/browse/HADOOP-639?page=comments#action_12456146 ] 
            
Arun C Murthy commented on HADOOP-639:
--------------------------------------

Mahadev, appreciate for your review/comments...

 I have something very similar to the above code except for a difference:

Since the KillJobAction is processed as a part of the 'heartbeat', I don't do 
the cleanup 'inline' (keep the heartbeat processin tight) ... and as exists I 
delegate the 'cleanup' part to the 'tasksToCleanup' thread which periodically 
wakes up and cleans-out tasks - I set a 'purgeJobFiles' flag for the last task 
in runningJobs['jobid'], and that lets 
TaskTracker.TaskInProgress.jobHasFinished to cleanup the job-dir.

Thoughts?

> task cleanup messages can get lost, causing task trackers to keep tasks 
> forever
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-639
>                 URL: http://issues.apache.org/jira/browse/HADOOP-639
>             Project: Hadoop
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.7.2
>            Reporter: Owen O'Malley
>         Assigned To: Arun C Murthy
>         Attachments: HADOOP-639_1.patch, HADOOP-639_2_20061130.patch, 
> HADOOP-639_3_20061201.patch, HADOOP-639_4_20061205.patch
>
>
> If the pollForTaskWithClosedJob call from a job tracker to a task tracker 
> times out when a job completes, the tasks are never cleaned up. This can 
> cause the mini m/r cluster to hang on shutdown, but also is a resource leak.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to