[
https://issues.apache.org/jira/browse/HADOOP-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462482
]
Sanjay Dahiya commented on HADOOP-801:
--------------------------------------
Updated patch with review comments, Thanks Owen for the review.
> 3. JobInProgress line ~294 has duplicated code for adding the new event
> depending on whether the task failed > or succeeded. It should just be:
TaskStatus.Status has a few more state transitions, we only want to generate an
event when Task is done so think that piece of code needs to be wrapped in
condition. so i think that should be ok.
> 1. I don't think it is a good idea to break control constructs between jsp
> escapes.:
Another issue when we use out.print() for more html output is that IDE can't do
any syntax validation and all issues will be discovered at runtime. In this
case its a small file so i guess its ok to use out.print()
> You could use JSTL, no?
That would be ideal, but we dont have jstl jars as part of hadoop as of now, we
can defer it until we successfully move to jetty6 which comes with this stuff
pre packaged.
> job tracker should keep a log of task completion and failure
> ------------------------------------------------------------
>
> Key: HADOOP-801
> URL: https://issues.apache.org/jira/browse/HADOOP-801
> Project: Hadoop
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.9.1
> Reporter: Owen O'Malley
> Assigned To: Sanjay Dahiya
> Fix For: 0.10.0
>
> Attachments: Hadoop-801.patch, Hadoop-801.patch, Hadoop-801.patch
>
>
> The JobTracker should track a list of task completion events in JobInProgress.
> So JobClientProtocol & InterTrackerProtocol should get a new method:
> TaskCompletionEvent[] getTaskCompletionEvents(String jobid, int
> fromEventId) throws IOException;
> TaskCompletionEvent should have:
> int getEventId();
> String getTaskTrackerHttp();
> String getTaskId();
> static public enum Status {FAILED, SUCCEEDED};
> Status getTaskStatus();
> }
> The events will be stored in a List<TaskCompletionEvent> and the eventId is
> the position in the list.
> These event logs will allow JobClient to display task output to the user as
> well as provide the start of the fix for HADOOP-248.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
