[ 
https://issues.apache.org/jira/browse/HADOOP-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463637
 ] 

Doug Cutting commented on HADOOP-758:
-------------------------------------

Rather than ignore all those exceptions, wouldn't it be better to at least log 
them?  Also, I'm not sure we need to proceed with all cleanups if any fail.  
And we shouldn't replicate the cleanup code.

The problem is that exceptions in cleanups are masking the exception thrown in 
the body.  Wouldn't something like the following work?

IOException ioe = null;
try {
  ... body ...
} catch (IOException e) {
   ioe = e;
   throw e;
} finally {
  try {
    ... cleanups...
  } catch (IOException e) {
    if (ioe != null) LOG.warn(e) else throw e;
  }
  if (ioe != null) throw ioe;
}
    

> FileNotFound on DFS block file
> ------------------------------
>
>                 Key: HADOOP-758
>                 URL: https://issues.apache.org/jira/browse/HADOOP-758
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.8.0
>            Reporter: Owen O'Malley
>         Assigned To: Raghu Angadi
>         Attachments: HADOOP-758.patch
>
>
> While run the sort benchmark a reduce failed with:
> java.io.FileNotFoundException: 
> /tmp/hadoop-oom/dfs/tmp/tmp/client-4362164194084664090 (No such file or 
> directory)
>       at java.io.FileInputStream.open(Native Method)
>       at java.io.FileInputStream.(FileInputStream.java:106)
>       at 
> org.apache.hadoop.dfs.DFSClient$DFSOutputStream.endBlock(DFSClient.java:1156)
>       at 
> org.apache.hadoop.dfs.DFSClient$DFSOutputStream.close(DFSClient.java:1244)
>       at java.io.FilterOutputStream.close(FilterOutputStream.java:143)
>       at java.io.FilterOutputStream.close(FilterOutputStream.java:143)
>       at java.io.FilterOutputStream.close(FilterOutputStream.java:143)
>       at 
> org.apache.hadoop.fs.FSDataOutputStream$Summer.close(FSDataOutputStream.java:98)
>       at java.io.FilterOutputStream.close(FilterOutputStream.java:143)
>       at java.io.FilterOutputStream.close(FilterOutputStream.java:143)
>       at java.io.FilterOutputStream.close(FilterOutputStream.java:143)
>       at org.apache.hadoop.io.SequenceFile$Writer.close(SequenceFile.java:515)
>       at 
> org.apache.hadoop.mapred.SequenceFileOutputFormat$1.close(SequenceFileOutputFormat.java:71)
>       at org.apache.hadoop.mapred.ReduceTask.run(ReduceTask.java:310)
>       at 
> org.apache.hadoop.mapred.TaskTracker$Child.main(TaskTracker.java:1271)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to