Nigel Daley wrote:
Currently, when I run checkstyle (with sun's style conventions, which
we use for Hadoop) I get tons of warnings on almost each and every
source file.
...which is perhaps one reason it is too late to use CheckStyle.
We can't use CheckStyle, but not for that reason: it's LGPL.
Also, we use Sun's style conventions with at least one modification: we
indent two spaces per level, not four.
Style changes should be done as separate commits and with some
hesitation, since they can break patch files and make it difficult to
trace the history of a file.
Doug
