[
https://issues.apache.org/jira/browse/HADOOP-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469137
]
Doug Cutting commented on HADOOP-954:
-------------------------------------
> if Hadoop currently needs only a subset of the functionality, it would make
> sense to create any
encapsulation of that subset somewhere outside of the metrics package
The metrics package is a part of Hadoop. It's architecturally wise to make it
standalone, but if there are utilities based on it that are generally useful,
they should be included with metrics, and not in some other utility package.
If these utilities are poorly designed then they should be fixed or discarded,
not simply moved elsewhere.
> We should get rid of the report method (there are about 2 dozen calls) and
> use the MetricsRecord API instead.
I'm okay with that, so long as it doesn't lead to a bunch of duplicated code.
If there are more than a few lines that are duplicated by different uses of the
metrics API, then these should be shared through a utility class, no?
> Should I submit a patch with these changes?
Yes, please. Thanks! It would be great to have the designer of the metrics
system make Hadoop's use of it exemplary.
> Metrics should offer complete set of static report methods or none at all
> -------------------------------------------------------------------------
>
> Key: HADOOP-954
> URL: https://issues.apache.org/jira/browse/HADOOP-954
> Project: Hadoop
> Issue Type: Improvement
> Components: metrics
> Affects Versions: 0.10.1
> Reporter: Nigel Daley
> Assigned To: David Bowen
> Priority: Minor
>
> org.apache.hadoop.metrics.Metrics currently has one report method. I should
> either have report methods for all underlying MetricsRecord or no report
> methods at all.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
