[
https://issues.apache.org/jira/browse/HADOOP-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476354
]
James P. White commented on HADOOP-1041:
----------------------------------------
David is the one who suggested sorting on the presentation name. My response
to that was that sorting on the key (Enum class name) should be retained (at
least as a user choice) even if he likes the presentation name sorting because
grouping by package is undoubtedly useful.
I am not familiar with the counter/enum code in question. If they are packaged
in multiple JARs (which I expect is the case), then a reasonable approach to
delegation is to use an interface:
public interface org.a.h....PresentableName {
String getPresentableName(String key);
}
That way if the code is in another JAR it can use it's own resource bundle (or
whatever).
> Counter names are ugly
> ----------------------
>
> Key: HADOOP-1041
> URL: https://issues.apache.org/jira/browse/HADOOP-1041
> Project: Hadoop
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.12.0
> Reporter: Owen O'Malley
> Fix For: 0.12.0
>
>
> Having the complete class name in the counter names makes them unique, but
> they are ugly to present to non-developers. It would be nice to have some way
> to have a nicer string presented to the user. Currently, the Enum is
> converted to a name like:
> key.getDeclaringClass().getName() + "#" + key.toString()
> which gives counter names like
> "org.apache.hadoop.examples.RandomWriter$Counters#BYTES_WRITTEN"
> which is unique, but not very user friendly. Perhaps, we should strip off the
> class name for presenting to the users, which would allow them to make nice
> names. In particular, you could define an enum type that overloaded toString
> to print a nice user friendly string.
> Thoughts?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
