[ 
https://issues.apache.org/jira/browse/HADOOP-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483701
 ] 

Doug Cutting commented on HADOOP-1148:
--------------------------------------

> My feeling is that we should fix compile warnings (HADOOP-958) before fixing 
> style warnings.

I don't feel strongly about the ordering.  Fixing those compilation warnings is 
a manual process, no?  And it may break existing patches.  So it is heavier 
weight, but I don't see why it must happen first.  

In both cases, a patch may be impractical, as it might soon become outdated.  
These are cases where, once we reach agreement, a committer might simply make 
and commit the change.

> re-indent all code
> ------------------
>
>                 Key: HADOOP-1148
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1148
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: Doug Cutting
>         Assigned To: Doug Cutting
>            Priority: Minor
>
> We should re-indent all code to consistently use 2-spaces per level.  This 
> will not invalidate outstanding patches: one can use the '-l' option to 
> ignore whitespace differences in patches.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to