[ 
https://issues.apache.org/jira/browse/HADOOP-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493182
 ] 

Raghu Angadi commented on HADOOP-1200:
--------------------------------------


You have replaced '{{shutdown(); throw iex;}}' with '{{checkDiskError(iex); 
throw iex;}}' . {{checkDiskError(iex);}} does not shutdown if checkDirs() does 
not throw DiskErrorException. Is this functionality change intentional? 

I am not sure why there was {{ shutdown(); }} in the first place and so this 
change might be ok. 

Another functionality change is that  {{data.invalidate(toDelete)}}'s exception 
is ignored in {{processCommand()}}.  This change is probably not necessary 
since {{offerService()}} already handles the exception.





> Datanode should periodically do a disk check
> --------------------------------------------
>
>                 Key: HADOOP-1200
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1200
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.12.2
>            Reporter: Hairong Kuang
>         Assigned To: Hairong Kuang
>            Priority: Blocker
>             Fix For: 0.13.0
>
>         Attachments: diskCheck.patch
>
>
> HADOOP-1170 removed the disk checking feature. But this is a needed feature 
> for maintaining a large cluster. I agree that checking the disk on every I/O 
> is too costly. A nicer approach is to have a thread that periodically do a 
> disk check. It then automatically decommissions itself when any error occurs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to