[ 
https://issues.apache.org/jira/browse/HADOOP-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497108
 ] 

Kurtis Heimerl commented on HADOOP-1298:
----------------------------------------

In response to Konstantin:

1)There's a tradeoff in that sort of structure. We'd remove the type safety of 
the methodology. It's like I said before, we could have a generic 
changeStuff(stuff, args) method that pushes that functionality all the way down 
to the permissions object or INode, but there's no reason that wouldn't include 
move or any other INode functionality currently implemented. This change would 
give us the ability to modify the INode without changing anyone along the 
pipeline. However, I don't  expect there to be a ton of functionality added, so 
the benefit of strongly typing and having clear execution paths is higher than 
the extensibility benefit, imo. Forcing any INode change to go through all 
levels gives a very clear idea of exactly what was changing and gives the 
ability to have higher levels catch it in other file systems. 

2) I have at least one optimization I could do, that being forcing permissions 
objects to use the same Integer objects if they share the same GID or 
UID.That's reasonable. 

I don't see the benefit of Enums in this case. I could see packing the shorts 
along the wire in an object, but what would we be enumerating? The 
USER_READABLE stuff? 

> adding user info to file
> ------------------------
>
>                 Key: HADOOP-1298
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1298
>             Project: Hadoop
>          Issue Type: New Feature
>          Components: dfs, fs
>            Reporter: Kurtis Heimerl
>         Attachments: hadoop-user-munncha.patch, hadoop-user-munncha.patch, 
> hadoop-user-munncha.patch, hadoop-user-munncha.patch10, 
> hadoop-user-munncha.patch11, hadoop-user-munncha.patch12, 
> hadoop-user-munncha.patch13, hadoop-user-munncha.patch14, 
> hadoop-user-munncha.patch15, hadoop-user-munncha.patch16, 
> hadoop-user-munncha.patch4, hadoop-user-munncha.patch5, 
> hadoop-user-munncha.patch6, hadoop-user-munncha.patch7, 
> hadoop-user-munncha.patch8, hadoop-user-munncha.patch9
>
>
> I'm working on adding a permissions model to hadoop's DFS. The first step is 
> this change, which associates user info with files. Following this I'll 
> assoicate permissions info, then block methods based on that user info, then 
> authorization of the user info. 
> So, right now i've implemented adding user info to files. I'm looking for 
> feedback before I clean this up and make it offical. 
> I wasn't sure what release, i'm working off trunk. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to