[
https://issues.apache.org/jira/browse/HADOOP-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hairong Kuang updated HADOOP-1411:
----------------------------------
Attachment: createRetry1.patch
The new patch reflects Tom's suggestions.
> I think if possible it would be better not to have a special case for
> ipc.RemoteException embedded in RetryPolicies.retryByException. Instead we
> could have another static factory, RetryPolicies.retryByRemoteException say,
> that should be used for remote interfaces.
I agree this interface is cleaner. But one disadvantage is that it is harder
for a client to use the framework to support RemoteException. A client needs to
build two exception2Policy maps and shouldRetry needs to be recusively called
one more time to search one more map.
> Also, note that the signature for this doesn't need to have a Map keyed by
> String: keying by Exception provides more type safety (at the slight cost of
> creating a new Map keyed by String for internal use) and consistency with
> RetryPolicies.retryByException.
I agree that keying by Exception provides more type safety. But again calling
Class.forName is more costly than calling Class.getName. That's why I perfer
usign class name as the map's key. Alternatively we could enforce type safety
by providing an "add" handler to the map with Exception as a parameter and
internally implements the map using the class name as the key. But we could do
it in a different jira.
> AlreadyBeingCreatedException from task retries
> ----------------------------------------------
>
> Key: HADOOP-1411
> URL: https://issues.apache.org/jira/browse/HADOOP-1411
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.13.0
> Reporter: Nigel Daley
> Assigned To: Hairong Kuang
> Priority: Blocker
> Fix For: 0.13.0
>
> Attachments: createRetry.patch, createRetry1.patch
>
>
> HADOOP-1407 indicates 2 bugs: a mapred bug which will be fixed as part of
> 1407, and a DFSClient bug that will be fixed here.
> Note that the test run in 1407 was without speculation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
