[
https://issues.apache.org/jira/browse/HADOOP-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499035
]
Enis Soztutar commented on HADOOP-1425:
---------------------------------------
Apart from the above code, I just cannot understand the lines in
ToolBase#processGeneralOptions():
{code}
if (line.hasOption("conf")) {
conf.addFinalResource(new Path(line.getOptionValue("conf")));
}
{code}
shouldn't we create a NEW configuration object from the given option value.
Let's say we have conf/hadop-default.xml and conf/hadoop-site.xml in our main
code, and also we have /tmp/foo_dir/conf/hadoop-site.xml. Then running
foo -conf /tmp/foo_dir/conf
will populate the configuratio from all the three files :
conf/hadoop-default.xml, conf/hadoop-site.xml, and
/tmp/foo_dir/conf/hadoop-site.xml. However although some of the parameters in
conf/hadoop-site.xml will be overriden by /etc/foo_dir/conf/hadoo-site.xml, the
parameters not listed in the latter will stay the same. Do we want such a
thing? i assume the use cases for -conf option will only want parameters from
the given conf directory.
> Rework the various programs in 'examples' to extend ToolBase
> -------------------------------------------------------------
>
> Key: HADOOP-1425
> URL: https://issues.apache.org/jira/browse/HADOOP-1425
> Project: Hadoop
> Issue Type: Improvement
> Components: examples
> Reporter: Arun C Murthy
> Assigned To: Enis Soztutar
> Priority: Minor
> Fix For: 0.14.0
>
>
> Ensuring all 'examples' extend ToolBase will make it easy to tweak various
> config params (via -D switches for e.g.) while running the programs...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
