[ 
https://issues.apache.org/jira/browse/HADOOP-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507930
 ] 

stack commented on HADOOP-1509:
-------------------------------

+1

Patch looks good to me and it built and passed all tests locally.  I'd suggest 
this issue is ripe for moving its state to 'patch available' so it gets picked 
up by hudson.

> Open HRegionServer/HClient for extension
> ----------------------------------------
>
>                 Key: HADOOP-1509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1509
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.14.0
>            Reporter: James Kennedy
>            Assignee: James Kennedy
>            Priority: Minor
>             Fix For: 0.14.0
>
>         Attachments: openForExtension-v2.patch, openForExtension-v3.patch, 
> openForExtension-v4.patch, openForExtension.patch
>
>
> For what i'm doing I found it necessary to extend 
> HRegionServer/HRegion/HClient for some custom functionality.
> Following good Java practice I see that the HBase code as been programmed 
> defensively, keeping stuff private as much as possible.
> However, for extensibility it would be nice if the servers/client were easy 
> to extend.
> Attached is a patch that makes several methods protected instead of private, 
> adds getters to fields of inner classes, and some other modifications i found 
> were useful for some simple extension code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to