[
https://issues.apache.org/jira/browse/HADOOP-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen O'Malley updated HADOOP-1601:
----------------------------------
Status: Open (was: Patch Available)
It looks good, but rather than compare class names, please compare the class
objects themselves.
ie. instead of {{if (clazz.getName().equals(instanceClassName) ...}} do {{if
(clazz == instanceClass) ... }}
You also have one line with a 4 space indent that should be 2 spaces.
> GenericWritable should use ReflectionUtils.newInstance to avoid problems with
> classloaders
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-1601
> URL: https://issues.apache.org/jira/browse/HADOOP-1601
> Project: Hadoop
> Issue Type: Bug
> Components: io
> Affects Versions: 0.15.0
> Reporter: Owen O'Malley
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: genericWritable_v1.0.patch
>
>
> GenericWritable currently uses Class.newInstance and it should use
> hadoop.utils.ReflectionUtils.newInstance. Furthermore, GenericWritable should
> be Configurable and should configure the nested objects. This will prevent a
> lot of classloader issues and allow the objects to get a configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
