[
https://issues.apache.org/jira/browse/HADOOP-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519801
]
Konstantin Shvachko commented on HADOOP-1712:
---------------------------------------------
# import Random can be removed.
# BlockCrcUpgradeObjectDatanode.doUpgrade() should not catch and re-throw
RuntimeException, because the framework
already catches Exception and loops. I don't see the point of catching the same
exception twice here.
# BlockCrcUpgradeObjectDatanode.doUpgrade() should be declared to throw an
IOException as the abstract declaration does.
> Unhandled exception in Block CRC upgrade on datanode.
> -----------------------------------------------------
>
> Key: HADOOP-1712
> URL: https://issues.apache.org/jira/browse/HADOOP-1712
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.14.0
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Priority: Blocker
> Fix For: 0.14.0
>
> Attachments: HADOOP-1712.patch
>
>
> One of the un-handled IOException during BlockCRC upgrade results in the
> upgrade thread to exit with out proper upgrade.
> exception on the datanode :
> {noformat}
> 2007-08-13 22:18:27,324 ERROR org.apache.hadoop.dfs.DataNode:
> java.io.IOException: Block blk_-6404399692543439055 is not valid.
> at org.apache.hadoop.dfs.FSDataset.getBlockFile(FSDataset.java:492)
> at
> org.apache.hadoop.dfs.BlockCrcUpgradeObjectDatanode.doUpgrade(BlockCrcUpgrade.java:1431)
> at
> org.apache.hadoop.dfs.UpgradeObjectDatanode.run(UpgradeObjectDatanode.java:95)
> at java.lang.Thread.run(Thread.java:619)
> {noformat}
> Will also check if there are any more of such misses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
