[
https://issues.apache.org/jira/browse/HADOOP-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HADOOP-1785:
--------------------------
Attachment: TableInputFormat.take4.patch
Add in missing file. Below is list of changes:
{code}
HADOOP-1785 TableInputFormat.TableRecordReader.next has a bug
M src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestTableMapReduce.java
(localTestSingleRegionTable, localTestMultiRegionTable, verify): Added.
M src/contrib/hbase/src/test/org/apache/hadoop/hbase/HBaseTestCase.java
Javadoc for addContents and Loader interface and implementations.
Methods have been made static so accessible w/o subclassing.
M src/contrib/hbase/src/test/org/apache/hadoop/hbase/MultiRegionTable.java
Guts of TestSplit has been moved here so other tests can have
access to a multiregion table.
M src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestSplit.java
Bulk moved to MultiRegionTable utility class. Use this new class
instead.
M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HTable.java
Added '@deprecated' javadoc.
M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HMaster.java
Was throwing RuntimeException when a msgQueue.put was interrupted
but this is a likely event on shutdown. Log a message instead.
M
src/contrib/hbase/src/java/org/apache/hadoop/hbase/mapred/TableInputFormat.java
Actually fix for HADOOP-1785... reverse test of row comparison.
{code}
> [HBase] TableInputFormat.TableRecordReader.next has a bug
> ---------------------------------------------------------
>
> Key: HADOOP-1785
> URL: https://issues.apache.org/jira/browse/HADOOP-1785
> Project: Hadoop
> Issue Type: Bug
> Components: contrib/hbase
> Reporter: Ning Li
> Assignee: Jim Kellerman
> Priority: Minor
> Attachments: TableInputFormat.patch, TableInputFormat.take2.patch,
> TableInputFormat.take3.patch, TableInputFormat.take4.patch
>
>
> TableInputFormat.TableRecordReader.next has the following:
> if (m_endRow.getLength() > 0 && (tKey.getRow().compareTo(m_endRow) < 0))
> hasMore = false;
> It should be:
> if (m_endRow.getLength() > 0 && (tKey.getRow().compareTo(m_endRow) >= 0))
> hasMore = false;
> TestTableMapReduce test passes because it tested map-reduce on a
> single-region table.
> The problem only shows on a multi-region table. The patch includes changes to
> TestTableMapReduce
> so map-reduce is tested on a multi-region table as well. The multi-region
> table is created
> in a similar way as done in TestSplit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
