[
https://issues.apache.org/jira/browse/HADOOP-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525860
]
irubin edited comment on HADOOP-1828 at 9/7/07 4:05 PM:
-------------------------------------------------------------
Hi there,
I'm attaching a new patch (shell_2.patch) which is a cleaned-up version of your
patch (shell.patch). I applied shell.patch to my local copy and diff-ed to get
shell_2.patch, which is significantly smaller. Shell.patch had a lot of
redundant adding and removing: it would remove large sections of code only to
re-add them with minor changes. I think there must have been something wrong
with the way you generated the patch.
As I was looking through the patch and my patched local copy, I noticed that
you didn't add the altools and rdf commands to the help list (although the
commands themselves and their shells worked fine). Also, the other commands
you added (like projection, group, sort, ...) seemed out of place. Is there a
need to have them in the patch when (for now) they have no corresponding action?
The altools and rdf sub-shells only seem to mimic the commands of the original
shell. I think think these sub-shells might be coming before their time; they
don't really have a purpose until there are unique commands and capabilities
for them to have.
-1
*for shell_2.patch, all tests passed on my local copy
was (Author: irubin):
Hi there,
I'm attaching a new patch (shell_2.patch) which is a cleaned-up version of your
patch (shell.patch). I applied shell.patch to my local copy and diff-ed to get
shell_2.patch, which is significantly smaller. Shell.patch had a lot of
redundant adding and removing: it would remove large sections of code only to
re-add them with minor changes. I think there must have been something wrong
with the way you generated the patch.
As I was looking through the patch and my patched local copy, I noticed that
you didn't add the altools and rdf commands to the help list (although the
commands themselves and their shells worked fine). Also, the other commands
you added (like projection, group, sort, ...) seemed out of place. Is there a
need to have them in the patch when (for now) they have no corresponding action?
The altools and rdf sub-shells only seem to mimic the commands of the original
shell. I think think these sub-shells might be coming before their time; they
don't really have a purpose until there are unique commands and capabilities
for them to have.
-1
> [Hbase Shell] Switch Command for sub-shell
> ------------------------------------------
>
> Key: HADOOP-1828
> URL: https://issues.apache.org/jira/browse/HADOOP-1828
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Affects Versions: 0.14.0
> Environment: All environments
> Reporter: Edward Yoon
> Fix For: 0.15.0
>
> Attachments: shell.patch, shell_2.patch
>
>
> This is a swtich command patch for the future implementation of sub-shell.
> {code}
> HBase > altools;
> Hbase altools, 0.0.1 version
> Type 'help;' for Hbase altools usage.
> HBase.Altools > help;
> Type 'help <command>;' to see command-specific usage.
> * Global commands.
> FS Hadoop FsShell operations.
> EXIT Exit shell
> SHOW List all tables.
> CLEAR Clear the screen.
> DESCRIBE Describe a table's columnfamilies.
> * Altools Commands.
> Projection ...
> HBase.Altools > exit;
> HBase > exit;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
