[
https://issues.apache.org/jira/browse/HADOOP-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526200
]
Izaak Rubin commented on HADOOP-1828:
-------------------------------------
Hi Yoon,
I understand your desire to communicate with the other shell project members,
and I agree that comments like these are a good way of doing so. However, I
think I should clarify that I myself am not working on the sub-shell
implementation; I was only asked to review the patch and give my feedback.
The main concern I had with your patch was that it was a bit open-ended and
ambiguous. The patch itself didn't make the direction or use of the sub-shell
clear; it would need additional patches to make an understandable
implementation of sub-shell. It's just my opinion that a patch should effect a
full, complete change without having to depend on future patches or issues.
> [Hbase Shell] Switch Command for sub-shell
> ------------------------------------------
>
> Key: HADOOP-1828
> URL: https://issues.apache.org/jira/browse/HADOOP-1828
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Affects Versions: 0.14.0
> Environment: All environments
> Reporter: Edward Yoon
> Fix For: 0.15.0
>
> Attachments: shell.patch, shell_2.patch
>
>
> This is a swtich command patch for the future implementation of sub-shell.
> {code}
> HBase > altools;
> Hbase altools, 0.0.1 version
> Type 'help;' for Hbase altools usage.
> HBase.Altools > help;
> Type 'help <command>;' to see command-specific usage.
> * Global commands.
> FS Hadoop FsShell operations.
> EXIT Exit shell
> SHOW List all tables.
> CLEAR Clear the screen.
> DESCRIBE Describe a table's columnfamilies.
> * Altools Commands.
> Projection ...
> HBase.Altools > exit;
> HBase > exit;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
