[ 
https://issues.apache.org/jira/browse/HADOOP-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526565
 ] 

Doug Cutting commented on HADOOP-1846:
--------------------------------------

> If it is not in hadoop-default.xml then why have it at all? Better to have a 
> static final instead.

It can't be a static final if we still want to change it to make unit tests run 
faster, right?

I think it's okay to have parameters that are undocumented in 
hadoop-default.xml.  These are akin to package-private fields: a useful way to 
share implementation internals without encouraging users to muck with them.  
Once something goes into hadoop-default.xml then it's public and we should 
continue to support it in future releases.

An alternative might be to use a package-private field or method, provided the 
unit test is in the same package as the parameter in question.


> DatanodeReport should distinguish live datanodes from dead datanodes
> --------------------------------------------------------------------
>
>                 Key: HADOOP-1846
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1846
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.14.1
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>             Fix For: 0.15.0
>
>         Attachments: datanodeReport.patch
>
>
> DatanodeReport returns both live and dead datanodes and there is no way to 
> distinguish live nodes from dead nodes. But some applications are interested 
> in only live datanodes.  I propose that instead of haveing one 
> datanodeReport, dfs supports two reports: liveDatanodeReport and 
> deadDatanodeReport.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to