[ 
https://issues.apache.org/jira/browse/HADOOP-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kate Rhodes updated HADOOP-1936:
--------------------------------

    Status: Patch Available  (was: Open)

Requesting code review of pach as per suggestion at 
http://wiki.apache.org/lucene-hadoop/HowToContribute

Please see the tickets notes about the AOutputCollector class and 
TestAOutputCollector needing to be renamed to something more in-line with 
Hadoop naming conventions and probably moved to a more appropriate directory.

> WordCount unit test plus a helper class to facilitate testing Mappers and 
> Reducers
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-1936
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1936
>             Project: Hadoop
>          Issue Type: Test
>          Components: examples
>            Reporter: Kate Rhodes
>            Priority: Trivial
>         Attachments: WordCountTestExampleAndOutputCollectorTestHelper.patch
>
>
> There are to pieces to this The first is a test for WordCount, not because 
> word count actually needed one but because it would be useful to beginners to 
> have an example of how to unit test Mappers and Reducers.
> The second piece is AOutputCollector and it's associated unit test 
> TestAOutputCollector. This is an abstract class that can be quickly extended 
> by a stub OutputCollector in your unit tests to collect the output from your 
> Mapper and Reducer tests and make it available for easy retreival when 
> testing to see if the fourth key that was emitted was the one you expected.  
> I think that this would be a useful tool to have in the main test folder but 
> wasn't sure where would be best to put it. Also, since nothing else in Hadoop 
> uses Hungarian notation you'll probably want to rename it. I didn't because 
> I'm not confident about the naming conventions here and figured that since it 
>  and its test probably wouldn't end up living in the same folder as WordCount 
> that you could just rename it when you moved it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to