[ 
https://issues.apache.org/jira/browse/HADOOP-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532545
 ] 

Hadoop QA commented on HADOOP-1997:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12367112/TestCheckpoint.patch
against trunk revision r581995.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests -1.  The patch failed contrib unit tests.

Test results: 
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/888/testReport/
Findbugs warnings: 
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/888/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/888/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/888/console

This message is automatically generated.

> TestCheckpoint fails on Windows
> -------------------------------
>
>                 Key: HADOOP-1997
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1997
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.15.0
>         Environment: Windows
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>            Priority: Blocker
>             Fix For: 0.15.0
>
>         Attachments: TestCheckpoint.patch
>
>
> The bug is in the test. TestCheckpoint opens edits files in order to verify 
> its length but does not close it, so the
> secondary name-node attempt to delete it (in order to move edits.new into it 
> on Win) fails.
> But this revealed 3 more bugs.
> - FSEditLog.purgeEditLog() in case of delete / rename failure calls 
> FSEditLog.processIOError(), which should have
> failed because all FSEditLog streams are closed by that time. It does not 
> because the condition for throwing the
> exception is incorrect.
> - In fact purgeEditLog() should call directly FSImage.processIOError() 
> because again all streams are closed.
> - FSImage.processIOError() should also throw an exception if number of 
> directories is <=1 rather than when it == 1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to