[
https://issues.apache.org/jira/browse/HADOOP-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533215
]
stack commented on HADOOP-1608:
-------------------------------
Hey Edward. Tests look great and thanks for picking up the new pattern where
commands take a Writer in the constructor. Here's a couple of comments on the
patch:
+ In TestBooleanExpression, you declare EXPRESSION but don't use it.
+ In TestBooleanTermFilter, you have a @SuppressWarnings on the hCluster yet
you use it later. In this class, I see a setup but no corresponding takeDown
shutting down the dfs and hbase mini clusters. It subclasses MultiRegionTable
but doesn't seem to make use of any of the parent methods. Does it? If not,
subclass HBaseTestCase or HBaseClusterTestCase instead.
+ Is the comparer class's name misspelled? Should it be Comparator?
+ InsertOneTableToAnother looks like it has general utility. Does it belong in
the hbase mapred package? (Should it be named InsertOneTableIntoAnother?).
Same for IdentityFilterMap?
+ The query package Selection class uses System.out logging. Add a logger?
+ Is it true that this patch does not add the new items to the shell?
+ Here are some old questions: What about variable names of more than one
character? Entering a variable name, is its value emitted?
> [HbaseShell] Relational Algrebra Operators
> ------------------------------------------
>
> Key: HADOOP-1608
> URL: https://issues.apache.org/jira/browse/HADOOP-1608
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Environment: All environments
> Reporter: Edward Yoon
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: patch_v01.txt, patch_v02.txt, patch_v03.txt,
> patch_v04.txt, patch_v05.txt, patch_v06.txt
>
>
> Development of relational algebra operators has begun.
> * Projection
> ** selects a subset of the columnfamilies of a relation
> ** Result = π ~column_list~ (Relation)
> {code}
> Hbase > Result = Relation.Projection('year','legnth');
> Hbase > save Result into table('result');
> {code}
> * Selection
> ** See : HADOOP-2003 issue's description
> {code}
> Hbase> Result = Relation.Selection(length > 100 and studioName = 'Fox');
> Hbase> save Result into table('result');
> {code}
> * Product
> * Rename
> * Group
> * Sort
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
