[ 
https://issues.apache.org/jira/browse/HADOOP-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542313
 ] 

Hadoop QA commented on HADOOP-2204:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12369470/HADOOP-2204.patch
against trunk revision r594715.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: 
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1096/testReport/
Findbugs warnings: 
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1096/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1096/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1096/console

This message is automatically generated.

> DFSTestUtil.waitReplication does not wait.
> ------------------------------------------
>
>                 Key: HADOOP-2204
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2204
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2204.patch
>
>
> This makes unit tests fail in unexpected ways.
> In DFSTestUtil.java :
> {code}
>   /** wait for the file's replication to be done */
>   static void waitReplication(FileSystem fs, Path fileName, short replFactor) 
>  throws IOException {
>     boolean good;
>     do {
>       good = true;
>       //... 'good' is never accessed 
>     } while(!good);
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to