[ 
https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun C Murthy updated HADOOP-1347:
----------------------------------

    Status: Open  (was: Patch Available)

Rajagopal, some review comments:

1. Looks like there are some indentation changes, could you please fix them?
2. I'm not sure what the use case for 'unset' is, I'm open to a debate about 
its merits. At the very least you should check if the property had been marked 
*final* before the unset.
3. Could you also enhance TestConfiguration and add a test-case for this? 

Thanks!

> Configuration XML bug: empty values
> -----------------------------------
>
>                 Key: HADOOP-1347
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1347
>             Project: Hadoop
>          Issue Type: Bug
>          Components: conf
>            Reporter: Eelco Lempsink
>            Assignee: Rajagopal Natarajan
>            Priority: Critical
>         Attachments: unset.patch
>
>
> The configuration parser doesn't handle empty values well:
> if ("value".equals(field.getTagName()) && field.hasChildNodes())
> This logic makes it impossible to 'unset' a field when loading multiple 
> configurations.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to