[
https://issues.apache.org/jira/browse/HADOOP-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543801
]
Hadoop QA commented on HADOOP-2232:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12369828/HADOOP-2232-1.patch
against trunk revision r596495.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests -1. The patch failed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1122/testReport/
Findbugs warnings:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1122/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1122/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1122/console
This message is automatically generated.
> Add option to disable nagles algorithm in the IPC Server
> --------------------------------------------------------
>
> Key: HADOOP-2232
> URL: https://issues.apache.org/jira/browse/HADOOP-2232
> Project: Hadoop
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.16.0
> Reporter: Clint Morgan
> Attachments: HADOOP-2232-1.patch
>
>
> While investigating hbase performance, I found a bottleneck caused by
> Nagles algorithm. For some reads I would get a bi-modal distribution
> of read times, with about half the times being around 20ms, and half
> around 200ms. I tracked this down to the well-known interaction between
> Nagle's algorithm and TCP delayed acknowledgments.
> I found that calling setTcpNoDelay(true) on the server's socket
> connection dropped all of my read times back to a constant 20 ms.
> I propose a patch to have this TCP_NODELAY option be configurable. The
> attacked patch allows one to set the TCP_NODELAY option on both the
> client and the server side. Currently this is defaulted to false
> (i.e., with Nagle's enabled).
> To see the effect, I have included a Test which provokes the issue by
> sending a MapWriteable over an IPC call. On my machine this test shows
> a speedup of 117 times when using TCP_NODELAY.
> These tests were done on OSX 10.4. Your milage may very with other
> TCP/IP implementation stacks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
