[ 
https://issues.apache.org/jira/browse/HADOOP-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544969
 ] 

Arun C Murthy commented on HADOOP-2202:
---------------------------------------

Nigel, do you know why that exception occured?

bq. As an aside, I always prefer to use the interface (e.g. List) rather than 
the concrete implementation (e.g. ArrayList) wherever possible, especially in 
methods which are in a public API (this is also recommended by Sun and many 
others). I notice the Job class exposes the depending jobs as an ArrayList, I 
think this should be changed to List. If you agree maybe a separate Jira issue 
is in order? I'm quite happy to code up a patch for it.

+1, please file a jira/patch for it.

Unfortunately, this would have to be an incompatible change. Sigh, _now_ is as 
good a time as any.

> JobControl.java generates compiler warnings with Java6
> ------------------------------------------------------
>
>                 Key: HADOOP-2202
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2202
>             Project: Hadoop
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.15.0
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2202-1.patch
>
>
> The following compiler warning is seen with Java6:
> {noformat}
>     [javac] 
> /home/cutting/src/hadoop/trunk/src/java/org/apache/hadoop/mapred/jobcontrol/Job.java:221:
>  warning: [unchecked] unchecked call to add(E) as a member of the raw type 
> java.util.ArrayList
>     [javac]       return this.dependingJobs.add(dependingJob);
>     [javac]                                    ^
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to