[
https://issues.apache.org/jira/browse/HADOOP-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546100
]
stack commented on HADOOP-2068:
-------------------------------
+ Each class needs a license. Copy one from adjacent hbase classes.
+ You have tabs in this patch. Need to replaced with two spaces.
+ Most of the imports per class are not pertinent (if you had eclipse working,
it'd help you here: smile)
+ You might instantiate HBaseConfiguration once and then pass it to each of the
handler classes in their constructors. Same for admin and table instances?
Otherwise, you'll have three copies of each?
+ Each of your new handlers needs at least a class comment as javadoc saying
what each does.
Otherwise, I think they way you have broken apart the fat REST class is a big
improvement.
> [hbase] RESTful interface
> -------------------------
>
> Key: HADOOP-2068
> URL: https://issues.apache.org/jira/browse/HADOOP-2068
> Project: Hadoop
> Issue Type: New Feature
> Components: contrib/hbase
> Reporter: stack
> Priority: Minor
> Attachments: rest-11-27-07-v2.patch, rest-11-27-07.3.patc,
> rest-11-27-07.patch, rest.patch
>
>
> A RESTful interface would be one means of making hbase accessible to clients
> that are not java. It might look something like the below:
> + An HTTP GET of http://MASTER:PORT/ outputs the master's attributes: online
> meta regions, list of tables, etc.: i.e. what you see now when you go to
> http://MASTER:PORT/master.jsp.
> + An HTTP GET of http://MASTER:PORT/TABLENAME: 200 if tables exists and
> HTableDescription (mimetype: text/plain or text/xml) or 401 if no such table.
> HTTP DELETE would drop the table. HTTP PUT would add one.
> + An HTTP GET of http://MASTER:PORT/TABLENAME/ROW: 200 if row exists and 401
> if not.
> + An HTTP GET of http://MASTER:PORT/TABLENAME/ROW/COLUMNFAMILY:
> HColumnDescriptor (mimetype: text/plain or text/xml) or 401 if no such table.
> + An HTTP GET of http://MASTER:PORT/TABLENAME/ROW/COLUMNNAME/: 200 and latest
> version (mimetype: binary/octet-stream) or 401 if no such cell. HTTP DELETE
> would delete the cell. HTTP PUT would add a new version.
> + An HTTP GET of http://MASTER:PORT/TABLENAME/ROW/COLUMNNAME/TIMESTAMP: 200
> (mimetype: binary/octet-stream) or 401 if no such cell. HTTP DELETE would
> remove. HTTP PUT would put this record.
> + Browser originally goes against master but master then redirects to the
> hosting region server to serve, update, delete, etc. the addressed cell
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
