[
https://issues.apache.org/jira/browse/HADOOP-2381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550240
]
Tsz Wo (Nicholas), SZE commented on HADOOP-2381:
------------------------------------------------
Codes look good. I have the following comments:
- > Regd the name getPermissions(), I included 's' even though it returns
FsPermission. getPermissions() flows better, but we can change that.
I think it is better to change it (i.e. getPermission(), no "s"). Otherwise it
won't be consistent with other codes. Also, use "permission" for all
FsPermission objects.
- Since we cannot make FsPermission immutable, is it better to return a new
object every time? Otherwise, it is a security hole.
- In RawLocalFileSystem.loadPermissions(), should it throws IOException (or
return null) if there is any exception? Otherwise, we cannot tell whether the
permission returned is real or just the default because the command failed.
- BTW, the program cannot be compiled after applied the patch
> Support permission information in FileStatus
> --------------------------------------------
>
> Key: HADOOP-2381
> URL: https://issues.apache.org/jira/browse/HADOOP-2381
> Project: Hadoop
> Issue Type: New Feature
> Components: fs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Raghu Angadi
> Fix For: 0.16.0
>
> Attachments: 2381_20071207.patch, HADOOP-2381.patch
>
>
> In HADOOP-2288, FileSystem API is changed to support access control.
> FileStatus should also be changed to support permission information.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
