[
https://issues.apache.org/jira/browse/HADOOP-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Enis Soztutar updated HADOOP-544:
---------------------------------
Attachment: id_v2.patch
This patch addresses Doug's comments.
Changes include :
* Id classes are now top level,
* acronyms are capitalized as JobID, etc,
* detailed javadoc is provided
* Public methods of JobClient, jobcontrol.Job, TaskReport and
TaskCompletionEvent are deprecated and new methods are introduced. Since we
cannot override methods by changing only the return values, some of the
get{Job|TIP|Task}ID() functions had to be renamed. This may not be nice, since
now there can be two functions
{code}
@Deprecated
String TaskReport.getTaskId() { ... }
public TaskInProgressID getTaskID() { ... }
String RunningJob.getJobID() ;
JobID RunningJob.getID();
{code}
but I can not think of another way to keep backwards compatibility. We may get
rid of the deprecated functions in 0.17. Until then we should live with them.
Changes to JobSubmissionProtocol is done directly instead of deprecating. (see
HADOOP-1643)
* an issue with TaskLogAppender from the previous patch is fixed.
> Replace the job, tip and task ids with objects.
> -----------------------------------------------
>
> Key: HADOOP-544
> URL: https://issues.apache.org/jira/browse/HADOOP-544
> Project: Hadoop
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.6.2
> Reporter: Owen O'Malley
> Assignee: Enis Soztutar
> Fix For: 0.16.0
>
> Attachments: id_v1.patch, id_v2.patch, id_wip1.patch
>
>
> I think that it is silly to have tools parsing the strings that the framework
> builds for task ids. I propose:
> class JobId implements Writable {
> public int getJobId() {...}
> }
> class TaskId implements Writable {
> public JobId getJobId();
> public boolean isMap() { ... }
> public int getTaskId() { ... }
> }
> class TaskAttemptId implements Writable {
> public TaskId getTaskId();
> public int getAttemptId();
> }
> each of the classes will have a toString() method that generates the current
> string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
