[
https://issues.apache.org/jira/browse/HADOOP-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553365
]
Hadoop QA commented on HADOOP-2466:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12371940/patch2466.txt
against trunk revision r605484.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1394/testReport/
Findbugs warnings:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1394/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1394/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1394/console
This message is automatically generated.
> FileInputFormat computeSplitSize() method, change visibility to protected and
> make it a member method
> -----------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2466
> URL: https://issues.apache.org/jira/browse/HADOOP-2466
> Project: Hadoop
> Issue Type: Improvement
> Environment: all
> Reporter: Alejandro Abdelnur
> Fix For: 0.15.2
>
> Attachments: patch2466.txt
>
>
> Currently the computeSplitSize() method is private and static. Because of
> this, to make a subclass of the FileInputFormat that changes the logic to
> compute the split size, the whole getSplits() method has to be rewritten.
> By making it a member method and protected the logic to compute the split
> size can be changed and the getSplits() method can be reused.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
