[
https://issues.apache.org/jira/browse/HADOOP-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553947
]
Adrian Woodhead commented on HADOOP-2268:
-----------------------------------------
So this patch is getting cancelled for the fact that I removed two blank lines?
Both of which IMHO are improvements. If it's necessary I can put the blank
lines in again, although I feel this is rather petty but hey.
As for the bigger picture, I agree that this has gone from what could be a
biggish improvement to a rather minor one but that's what Doug wanted so as not
to introduce backward compatibility issues. And hey, rather a minor improvement
than no improvement at all...
> JobControl classes should use interfaces rather than implemenations
> -------------------------------------------------------------------
>
> Key: HADOOP-2268
> URL: https://issues.apache.org/jira/browse/HADOOP-2268
> Project: Hadoop
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.15.0
> Reporter: Adrian Woodhead
> Assignee: Adrian Woodhead
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: HADOOP-2268-1.patch, HADOOP-2268-2.patch,
> HADOOP-2268-3.patch
>
>
> See HADOOP-2202 for background on this issue. Arun C. Murthy agrees that when
> possible it is preferable to program against the interface rather than a
> concrete implementation (more flexible, allows for changes of the
> implementation in future etc.) JobControl currently exposes running, waiting,
> ready, successful and dependent jobs as ArrayList rather than List. I propose
> to change this to List.
> I will code up a patch for this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
