[
https://issues.apache.org/jira/browse/HADOOP-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554091
]
dhruba borthakur commented on HADOOP-2110:
------------------------------------------
1. In BlockListAsLongs() , you access iBlockList before checking whether it is
null.
2. Also, BlockListAsLongs() constructor checks th condition "if
(iBlockList.length%LONGS_PER_BLOCK != 0)" twice.
3. There should be no "public" methods in BlockListAsLongs. These methods
should be package private.
All other portions of code looks good. +1.
> Block Report Optimization: Replace class instance
> -------------------------------------------------
>
> Key: HADOOP-2110
> URL: https://issues.apache.org/jira/browse/HADOOP-2110
> Project: Hadoop
> Issue Type: Sub-task
> Components: dfs
> Affects Versions: 0.14.0
> Reporter: Robert Chansler
> Assignee: Sanjay Radia
> Fix For: 0.16.0
>
> Attachments: brAsLongsPatch2.txt, brAsLongsPatch3.txt, comaprison.txt
>
>
> Block report processing can be more efficient if instances of the block ID
> class are replaced with a sequence of longs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
