[ https://issues.apache.org/jira/browse/HADOOP-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HADOOP-2518: ---------------------------------- Attachment: 2518.patch Here's my go at the refactor described above. Files modified: D src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestHStoreFile.java D src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestHMemcache.java A src/contrib/hbase/src/test/org/apache/hadoop/hbase/store A src/contrib/hbase/src/test/org/apache/hadoop/hbase/store/TestHStoreFile.java A src/contrib/hbase/src/test/org/apache/hadoop/hbase/store/TestHMemcache.java M src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestCompaction.java M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HLogKey.java D src/contrib/hbase/src/java/org/apache/hadoop/hbase/HStoreFile.java D src/contrib/hbase/src/java/org/apache/hadoop/hbase/HStore.java M src/contrib/hbase/src/java/org/apache/hadoop/hbase/BloomFilterDescriptor.java M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HLog.java M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HMaster.java A src/contrib/hbase/src/java/org/apache/hadoop/hbase/store A src/contrib/hbase/src/java/org/apache/hadoop/hbase/store/CompactionReader.java A src/contrib/hbase/src/java/org/apache/hadoop/hbase/store/HStoreSize.java A src/contrib/hbase/src/java/org/apache/hadoop/hbase/store/Memcache.java A src/contrib/hbase/src/java/org/apache/hadoop/hbase/store/HStore.java A src/contrib/hbase/src/java/org/apache/hadoop/hbase/store/HStoreFile.java A src/contrib/hbase/src/java/org/apache/hadoop/hbase/store/StoreFileScanner.java A src/contrib/hbase/src/java/org/apache/hadoop/hbase/store/MapFileCompactionReader.java A src/contrib/hbase/src/java/org/apache/hadoop/hbase/store/HStoreScanner.java M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HAbstractScanner.java M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HRegion.java > [hbase] Refactor HStore and internal (and related) classes into hbase.store > subpackage > -------------------------------------------------------------------------------------- > > Key: HADOOP-2518 > URL: https://issues.apache.org/jira/browse/HADOOP-2518 > Project: Hadoop > Issue Type: Improvement > Components: contrib/hbase > Reporter: Bryan Duxbury > Assignee: Bryan Duxbury > Priority: Minor > Attachments: 2518.patch > > > HStore, the class responsible for managing data storage for column families > within a region, is a very large class with more than a few internal classes. > I propose moving HStore and HStoreFile into the hbase.store subpackage, and > then moving internal classes out of HStore and into their own > package-internal classes within the subpackage. This will make the code much > more readable and manageable. In addition, it will help to logically > delineate which classes are involved in managing a store. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.