[ 
https://issues.apache.org/jira/browse/HADOOP-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HADOOP-2553:
--------------------------

    Attachment: white-v2.patch

Remove unnecessary HStoreKey creation

> [hbase] Don't make Long objects calculating hbase type hash codes
> -----------------------------------------------------------------
>
>                 Key: HADOOP-2553
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2553
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>            Reporter: stack
>            Priority: Minor
>             Fix For: 0.16.0
>
>         Attachments: white-v2.patch, white.patch
>
>
> From a code perusal by Tom White:
> {code}
> ...
> 1. In Memcache.internalGet the following line doesn't seem to do anything.
> curKey.setVersion(itKey.getTimestamp() - 1);
> So why have curKey at all? Am I missing something?
> 2. Hashcode for HStoreKey (and others) uses the form Long.valueOf(...)
> for long fields. This creates an object each time - not sure if it's a
> problem (probably isn't) but as you've been doing some profiling I
> thought I'd mention it.
> ...
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to