[
https://issues.apache.org/jira/browse/HADOOP-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558708#action_12558708
]
Bryan Duxbury commented on HADOOP-2599:
---------------------------------------
@stack: Regarding the third suggestion, are you indicating that we need a new
class to hold a method that can append an unreasonably large timestamp onto a
table name? Does the method seem complex enough to warrant that? If we create
an HTableInfo class, what else would go in it?
> [hbase] Some minor improvements to changes in HADOOP-2443
> ---------------------------------------------------------
>
> Key: HADOOP-2599
> URL: https://issues.apache.org/jira/browse/HADOOP-2599
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
>
> Stack made a number of suggestions for improvements in the code changes from
> HADOOP-2443:
> Here in HConnectionManager:
> + scannerId = server.openScanner(
> + metaLocation.getRegionInfo().getRegionName(),
> + COLUMN_FAMILY_ARRAY, EMPTY_START_ROW, LATEST_TIMESTAMP,
> + null);
> ... EMPTY_START_ROW will work but 'startRow' would be easier to read (It'd
> work too - right?).
> Here:
> + } while (startRow.compareTo(EMPTY_START_ROW) != 0);
> .. EMPTY_ROW or a new define, LAST_ROW, would have been more readable, don't
> you think?
> This 999... 'trick' should be done as a method - in HTableInfo? - since you
> do it twice:
> + Text tableKey = new Text(tableName.toString() + ",,99999999999999");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
