[ 
https://issues.apache.org/jira/browse/HADOOP-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559736#action_12559736
 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-1742:
------------------------------------------------

Thank you for fixing the docs.  I have a few comments below.

- In ClientProtocol:
line 92: add a comma after "Once created"
line 95: add "by" after "abandoned implicitly"
line 111: wraped => wrapped

- Some javadocs (e.g. ClientProtocol.create(...)) are showed in single big 
paragraphs in the generated html.  I suggest to use <p> tag (instead of empty 
lines) to enclose paragraphs.

- Could you also remove the unrelated docs above DFSClient.rename(...) and 
DFSClient.delete(...)?

> FSNamesystem.startFile()  javadoc is inconsistent
> -------------------------------------------------
>
>                 Key: HADOOP-1742
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1742
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.14.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>            Priority: Minor
>             Fix For: 0.16.0
>
>         Attachments: JDocCorrect.patch, JDocCorrect.patch, JDocCorrect.patch
>
>
> FSNamesystem.startFile()  description should be updated. 
> It talks about arrays of blocks that are supposed to be returned, but returns 
> void.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to