[ 
https://issues.apache.org/jira/browse/HADOOP-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559760#action_12559760
 ] 

hairong edited comment on HADOOP-2566 at 1/16/08 4:27 PM:
----------------------------------------------------------------

Thanks Raghu! You comment relieved my mind. Don't want to have a wrong 
algorithm right before the feature freeze.

Regarding the regression, yes, I removed what HADOOP-2151 did because I think 
it is not efficient to call exist for each component when there is a glob on 
the path. My algorithm depends on getFileStatus to throw an exception that 
indicates an non-existent path. It works on dfs. But 
LocalFileSystem.getFileStatus returns a valid FileStatus object on a 
non-existent path. I will fix this. I'd like to change the semantics of 
getFileStaus to return null on a non-existent path. Thanks for helping me test 
this feature.

      was (Author: hairong):
    Thanks Raghu! You comment relieved my mind. Don't want to have a wrong 
algorithm right before the feature freeze.

Regarding the regression, yes, I removed what HADOOP-2151 did because I think 
it is not efficient to call exist for each component when there is a glob on 
the path. My algorithm depends on getFileStatus to throw an exception that 
indicates an non-existent path. It works on dfs. But 
LocalFileSystem.getFileStatus returns a valid FileStatus object. I will fix 
this. I'd like to change the semantics of getFileStaus to return null on a 
non-existent path. Thanks for helping me test this feature.
  
> need FileSystem#globStatus method
> ---------------------------------
>
>                 Key: HADOOP-2566
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2566
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Doug Cutting
>            Assignee: Hairong Kuang
>             Fix For: 0.16.0
>
>         Attachments: globStatus.patch, globStatus1.patch
>
>
> To remove the cache of FileStatus in DFSPath (HADOOP-2565) without hurting 
> performance, we must use file enumeration APIs that return FileStatus[] 
> rather than Path[].  Currently we have FileSystem#globPaths(), but that 
> method should be deprecated and replaced with a FileSystem#globStatus().
> We need to deprecate FileSystem#globPaths() in 0.16 in order to remove the 
> cache in 0.17.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to