[ 
https://issues.apache.org/jira/browse/HADOOP-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560189#action_12560189
 ] 

Konstantin Shvachko commented on HADOOP-2549:
---------------------------------------------

Yes, that should turn on volume switching if one of them is full.
Some comments.
- It is better to move declaration of estimateBlockSize up together with all 
other member declarations
- Use JavaDoc style comment for estimateBlockSize instead of the regular ones. 
That way I can see the description whenever I move the cursor over the variable 
in Eclipse.
- Do we plan to apply it to previous releases 0.14 or 0.15? If not then could 
you please also remove unused pieces of code
-# import org.apache.hadoop.io.Text;
-# private void enumerateThreadGroup()
-# short opStatus



> hdfs does not honor dfs.du.reserved setting
> -------------------------------------------
>
>                 Key: HADOOP-2549
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2549
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.14.4
>         Environment: FC Linux.
>            Reporter: Joydeep Sen Sarma
>            Assignee: Hairong Kuang
>            Priority: Critical
>         Attachments: diskfull.patch, diskfull1.patch
>
>
> running 0.14.4. one of our drives is smaller and is always getting disk full. 
> i reset the disk reservation to 1Gig - but it was filled quickly again.
> i put in some tracing in getnextvolume. the blocksize argument is 0. so every 
> volume (regardless of available space) qualifies. here's the trace:
> /* root disk chosen with 0 available bytes. format is 
> <available>:<blocksize>*/
> 2008-01-08 08:08:51,918 WARN org.apache.hadoop.dfs.DataNode: Volume 
> /var/hadoop/tmp/dfs/data/current:0:0
> /* some other disk chosen with 300G space. */
> 2008-01-08 08:09:21,974 WARN org.apache.hadoop.dfs.DataNode: Volume 
> /mnt/d1/hdfs/current:304725631026:0
> i am going to default blocksize to something reasonable when it's zero for 
> now.
> this is driving us nuts since our automounter starts failing when we run out 
> of space. so everything's broke.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to