[
https://issues.apache.org/jira/browse/HADOOP-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560580#action_12560580
]
Hadoop QA commented on HADOOP-1195:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12373473/datanodeNullPointer.patch
against trunk revision r613115.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests -1. The patch failed contrib unit tests.
Test results:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1642/testReport/
Findbugs warnings:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1642/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1642/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1642/console
This message is automatically generated.
> NullPointerException in FSNamesystem due to getDatanode() return value is not
> checked
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-1195
> URL: https://issues.apache.org/jira/browse/HADOOP-1195
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Reporter: Konstantin Shvachko
> Assignee: dhruba borthakur
> Fix For: 0.16.0
>
> Attachments: datanodeNullPointer.patch
>
>
> FSNamesystem.getDatanode( nodeID ) returns null if the node is not found.
> There are several places where we do not check wether the returned node is
> null, e.g.
> FSNamesystem.processReport()
> FSNamesystem.setDatanodeDead()
> FSNamesystem.invalidateBlock()
> FSNamesystem.verifyNodeRegistration()
> I'm getting the following NPE:
> 07/04/02 17:31:50 WARN dfs.DataNode: org.apache.hadoop.ipc.RemoteException:
> java.io.IOException: java.lang.NullPointerException
> at
> org.apache.hadoop.dfs.FSNamesystem.shouldNodeShutdown(FSNamesystem.java:3306)
> at
> org.apache.hadoop.dfs.FSNamesystem.processReport(FSNamesystem.java:2012)
> at org.apache.hadoop.dfs.NameNode.blockReport(NameNode.java:654)
> at sun.reflect.GeneratedMethodAccessor7.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:585)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:341)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:580)
> at org.apache.hadoop.ipc.Client.call(Client.java:473)
> at org.apache.hadoop.ipc.RPC$Invoker.invoke(RPC.java:164)
> at org.apache.hadoop.dfs.$Proxy1.blockReport(Unknown Source)
> at org.apache.hadoop.dfs.DataNode.offerService(DataNode.java:460)
> at org.apache.hadoop.dfs.DataNode.run(DataNode.java:1095)
> at
> org.apache.hadoop.dfs.MiniDFSCluster$DataNodeRunner.run(MiniDFSCluster.java:160)
> at java.lang.Thread.run(Thread.java:595)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
