[ https://issues.apache.org/jira/browse/HADOOP-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560614#action_12560614 ]
Hadoop QA commented on HADOOP-2284: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12373347/HADOOP-2284.patch against trunk revision r613115. @author +1. The patch does not contain any @author tags. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new compiler warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests -1. The patch failed core unit tests. contrib tests -1. The patch failed contrib unit tests. Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1643/testReport/ Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1643/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1643/artifact/trunk/build/test/checkstyle-errors.html Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1643/console This message is automatically generated. > BasicTypeSorterBase.compare calls progress on each compare > ---------------------------------------------------------- > > Key: HADOOP-2284 > URL: https://issues.apache.org/jira/browse/HADOOP-2284 > Project: Hadoop > Issue Type: Bug > Components: mapred > Reporter: Owen O'Malley > Assignee: Amar Kamat > Fix For: 0.16.0 > > Attachments: HADOOP-2284.patch > > > The inner loop of the sort is calling progress on each compare. I think it > would make more sense to call progress in the sort rather than the compare or > at most every 10000 compares. In the performance numbers, the call to > progress as part of the sort are consuming 12% of the total cpu time when > running word count under the local runner. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.