[ https://issues.apache.org/jira/browse/HADOOP-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560475#action_12560475 ]
stack commented on HADOOP-2654: ------------------------------- Patch looks good Stu. Does it say anywhere that this counter is byte-wide? (I don't see it on a quick check of the code) Is this value that is being incremented, the "3 or 4 bit counter" that is referred to in the wikipedia article? Thanks. > CountingBloomFilter can overflow its storage > -------------------------------------------- > > Key: HADOOP-2654 > URL: https://issues.apache.org/jira/browse/HADOOP-2654 > Project: Hadoop > Issue Type: Bug > Components: contrib/hbase > Reporter: Stu Hood > Attachments: counting-overflow.patch > > > The org.onelab.filter.CountingBloomFilter implementation does not check the > value of a bucket before incrementing/decrementing it. The buckets in a > Counting Bloom filter must not be allowed to overflow, and if they reach > their maximum value, they must not be allowed to decrement. This is the only > way to preserve the assumptions of the filter (without larger buckets). See: > http://en.wikipedia.org/wiki/Bloom_filter#Counting_filters > Currently, if enough values hash to a bucket, the CountingBloomFilter may > begin reporting false negatives when it wraps back around to 0. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.