[ https://issues.apache.org/jira/browse/HADOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560791#action_12560791 ]
Hadoop QA commented on HADOOP-2659: ----------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12373580/2659_20080118b.patch against trunk revision r613499. @author +1. The patch does not contain any @author tags. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new compiler warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests +1. The patch passed contrib unit tests. Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1659/testReport/ Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1659/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1659/artifact/trunk/build/test/checkstyle-errors.html Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1659/console This message is automatically generated. > The commands in DFSAdmin should require admin privilege > ------------------------------------------------------- > > Key: HADOOP-2659 > URL: https://issues.apache.org/jira/browse/HADOOP-2659 > Project: Hadoop > Issue Type: Bug > Components: dfs > Reporter: Tsz Wo (Nicholas), SZE > Assignee: Tsz Wo (Nicholas), SZE > Attachments: 2659_20080118.patch, 2659_20080118b.patch > > > The commands in DFSAdmin and the corresponding RPC calls should require admin > privilege. > DFSAdmin commands: > -report > -safemode > -refreshNodes > -finalizeUpgrade > -upgradeProgress > -metasave > ClientProtocol: > {code} > public void renewLease(String clientName) throws IOException; > public long[] getStats() throws IOException; > public DatanodeInfo[] getDatanodeReport(FSConstants.DatanodeReportType type) > throws IOException; > public boolean setSafeMode(FSConstants.SafeModeAction action) throws > IOException; > public void refreshNodes() throws IOException; > public void finalizeUpgrade() throws IOException; > public UpgradeStatusReport distributedUpgradeProgress(UpgradeAction action) > throws IOException; > public void metaSave(String filename) throws IOException; > {code} -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.