[
https://issues.apache.org/jira/browse/HAMA-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624577#action_12624577
]
hudson commented on HAMA-38:
----------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12388714/HAMA-38_v01.patch
against trunk revision 687945.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 3 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler
warnings.
release audit +1. The applied patch does not generate any new release
audit warnings.
findbugs -1. The patch appears to introduce new Findbugs warnings.
core tests -1. The patch failed core unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hama-Patch/38/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hama-Patch/38/artifact/trunk/build/reports/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hama-Patch/38/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/38/console
This message is automatically generated.
> Remove AbstractBase and make a new NumericUtil which is contains all numeric
> utilities.
> ---------------------------------------------------------------------------------------
>
> Key: HAMA-38
> URL: https://issues.apache.org/jira/browse/HAMA-38
> Project: Hama
> Issue Type: Improvement
> Components: implementation
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.1.0
>
> Attachments: HAMA-38.patch, HAMA-38_v01.patch
>
>
> Instead of AbstractBase, make a Numeric class which is contains all numeric
> utilities.
> ----
> Hello,
> AbstractBase seems to be totally a helper, rather than a base class.
> It's just for providing utility methods to use in a matrix.
> I propose to get rid of it and change it to be a helper, with static methods.
> Then we can use "import static" (a Java 5 feature) to import all
> static methods, and use them in the same way as the current
> implementation.
> Because AbstractBase has no state, and all of its methods has no
> side-effect, so it is not necessary to be in the class hierarchy.
> Regards,
> Chanwit
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
