[
https://issues.apache.org/jira/browse/HAMA-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627062#action_12627062
]
Hudson commented on HAMA-45:
----------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12389012/HAMA-47.patch
against trunk revision 689017.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
patch -1. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/52/console
This message is automatically generated.
> Add method's parameter order in a Vector and Matrix interface
> --------------------------------------------------------------
>
> Key: HAMA-45
> URL: https://issues.apache.org/jira/browse/HAMA-45
> Project: Hama
> Issue Type: Improvement
> Components: interface
> Affects Versions: 0.1.0
> Reporter: Suh Changhee
> Assignee: Suh Changhee
> Priority: Minor
> Fix For: 0.1.0
>
> Attachments: HAMA-47.patch
>
>
> In a Vector interface and Matrix interface, some "add" method has a little
> confusing parameter order.
> -> public Vector add(double alpha, Vector v);
> Parameter v is a target, alpha is a value.
> I think the target parameter appearing first is more clearer.
>
> For example, see another "add" method
> -> public void add(int index, double value);
> or "set" method.
> -> public void set(int index, double value);
> Index(target) parameter is first.
>
> I'm goint to patch it.
>
> Please advise.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
