[ 
https://issues.apache.org/jira/browse/HAMA-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644006#action_12644006
 ] 

Hudson commented on HAMA-5:
---------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12393066/HAMA-5_v01.patch
against trunk revision 708885.

    @author +1.  The patch does not contain any @author tags.

    tests included -1.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    patch -1.  The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/105/console

This message is automatically generated.

> More Comments for maintainable code
> -----------------------------------
>
>                 Key: HAMA-5
>                 URL: https://issues.apache.org/jira/browse/HAMA-5
>             Project: Hama
>          Issue Type: Improvement
>          Components: documentation 
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>            Priority: Critical
>             Fix For: 0.1.0
>
>         Attachments: HAMA-5_v01.patch
>
>
> The comments are more important than code.
> I'll add more comments since I wrote almost all of that part of the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to