[
https://issues.apache.org/jira/browse/HAMA-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708322#action_12708322
]
Hudson commented on HAMA-183:
-----------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12407842/HAMA-183.patch
against trunk revision 773593.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 12 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler
warnings.
release audit +1. The applied patch does not generate any new release
audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hama-Patch/174/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hama-Patch/174/artifact/trunk/build/reports/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hama-Patch/174/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/174/console
This message is automatically generated.
> When we construct the matrix, dimensions should be defined.
> -----------------------------------------------------------
>
> Key: HAMA-183
> URL: https://issues.apache.org/jira/browse/HAMA-183
> Project: Hama
> Issue Type: Bug
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Edward J. Yoon
> Fix For: 0.1.0
>
> Attachments: HAMA-183.patch
>
>
> "DenseMatrix a = new DenseMatrix(conf);" is odd to me. IMO, dimensions should
> be defined by constructor as "DenseMatrix a = new DenseMatrix(conf, 10, 10);"
> and, the values can't be set to out of range.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
