[
https://issues.apache.org/jira/browse/HAMA-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edward J. Yoon resolved HAMA-283.
---------------------------------
Fix Version/s: 0.2.0
Resolution: Fixed
I've just committed this. hard coded path of conf files also removed.
Thanks Filipe.
> Duplicate code regarding default configuration files for Hama
> -------------------------------------------------------------
>
> Key: HAMA-283
> URL: https://issues.apache.org/jira/browse/HAMA-283
> Project: Hama
> Issue Type: Question
> Reporter: Filipe Manana
> Assignee: Filipe Manana
> Priority: Trivial
> Fix For: 0.2.0
>
> Attachments: HAMA-283.patch
>
>
> While doing my first Hama code walks, I noticed the exact same static block
> initializer in the classes BSPMaster, GroomServer and BSPJobContext:
> static {
> Configuration.addDefaultResource("hama-default.xml");
> Configuration.addDefaultResource("hama-site.xml");
> }
> However, in the org.apache.hama.HamaConfiguration class the constructor
> calls the following method:
> private void addHamaResources() {
> Configuration.addDefaultResource("hama-default.xml");
> Configuration.addDefaultResource("hama-site.xml");
> }
> Correct me if I'm wrong, but this does exactly the same, right?
> With the following patch, which removes the static initializers, all the
> tests are passing.
> cheers
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
