[
https://issues.apache.org/jira/browse/HAMA-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247131#comment-13247131
]
Edward J. Yoon commented on HAMA-508:
-------------------------------------
Looks good.
However, 'mvn clean' deletes target directory by default as described here:
http://maven.apache.org/plugins/maven-clean-plugin/examples/delete_additional_files.html
So, we don't need to add this line.
{code}
+ <include>**/target/surefire-reports</include>
{code}
And, I've changed two lines in your patch like this.
{code}
<include>lib/**</include>
<include>logs/**</include>
{code}
Rest are good. I've just committed this, Thanks Mikalai!
> Add clean plugin
> ----------------
>
> Key: HAMA-508
> URL: https://issues.apache.org/jira/browse/HAMA-508
> Project: Hama
> Issue Type: Improvement
> Components: build
> Reporter: Edward J. Yoon
> Assignee: Mikalai Parafeniuk
> Priority: Minor
> Labels: newbie
> Fix For: 0.5.0
>
> Attachments: HAMA-508.patch
>
>
> Current build copies dependencies to lib directory, and daemons creates a log
> of its activities in log directory.
> To fully clean project w/ mvn clean command, we can use clean plugin[1].
> 1.
> http://maven.apache.org/plugins/maven-clean-plugin/examples/delete_additional_files.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
