The answer came in my dreams lol. We forgot to send the message to the vertex itself. In the old code the "self" vertex was in the adjecency list.
I fix that ASAP. Am 05.05.2012 23:56 schrieb "Thomas Jungblut (JIRA)" <[email protected]>: > > [ > https://issues.apache.org/jira/browse/HAMA-556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] > > Thomas Jungblut updated HAMA-556: > --------------------------------- > > Attachment: HAMA-556.patch > > Added aggregators, not tested more than a localrunner with a single task. > > The error accumulation works, however I have somehow broken pagerank: Sum > is: 0.7475461787313158 > > I have to investigate it further, but I have seen that the testcase was > useless anyways: > > > https://svn.apache.org/repos/asf/incubator/hama/trunk/examples/src/test/java/org/apache/hama/examples/PageRankTest.java > > In the current trunk version it just checks if the sum is in between 0 and > 1, which is always the case. > This does really not say that pagerank is working correct. > > Seems that this got broken when we translated the old pagerank. > > Should we put the aggregators into another package? Same with the > combiners? > > BTW I added my connected component special vertex :) It is much more > cleaner than that of giraph. > > Maybe we can add a list of aggregators, instead of just one later. > > IMHO, the not working pagerank is a blocker. > > > Graph package to support stopping the interations when the node changes > are within the tolerance value as in the case of page rank > > > ---------------------------------------------------------------------------------------------------------------------------------- > > > > Key: HAMA-556 > > URL: https://issues.apache.org/jira/browse/HAMA-556 > > Project: Hama > > Issue Type: New Feature > > Components: bsp core > > Affects Versions: 0.5.0 > > Reporter: praveen sripati > > Assignee: Thomas Jungblut > > Priority: Minor > > Fix For: 0.6.0 > > > > Attachments: HAMA-556.patch > > > > > > Currently in the graph package, the iteration continues till the nodes > are no longer updated (absolutely) or the maximum number of iterations has > reached. It doesn't support testing the node changes with some tolerance > and then stop the iterations as in the case of page rank. > > The above scenario might be applicable besides page rank also. > > org.apache.hama.graph.GraphJobRunner#bsp() > > while (updated && iteration < maxIteration) { > > ...... > > ...... > > } > > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA > administrators: > https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa > For more information on JIRA, see: http://www.atlassian.com/software/jira > > >
