On 7/21/07, Nathan Weizenbaum <[EMAIL PROTECTED]> wrote: > > > * Could you separate these into two patches, one for the options and > one for the filters?
The OPTIONS patch is here: http://pastie.caboo.se/80970 But the other patch is both options and filters: http://pastie.caboo.se/80984 (sorry, there was overlap between the two in Engine#initialize) * I like that red/bluecloth aren't required for unit tests, but that > shouldn't be accomplished by just not testing them. Ideally, if > they exist, they should be tested, but if they don't, it should > output a non-fatal error message. Well, "test_lazy_filter_loading" tests for red/bluecloth filters, only the tests that tested the functionality of the two were removed. All Filters conform to the same API, and that API is thoroughly tested within current unit tests. There is no sense to set up source and expected Markdown/Textile code in unit tests since this tests for their features, not inclusion. That is my reasoning for removing it. * I want Haml to throw an exception if a user tries to use one of > these filters when it's not installed. Done, LoadError is not rescued anymore. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Haml" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/haml?hl=en -~----------~----~----~----~------~----~------~--~---
